-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORC-1246: Revamp ORC website #1217
Conversation
cc: @dongjoon-hyun , @wgtmac , @pgaref , @guiyanakuang , @stiga-huang , @pavibhai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @williamhyun . This is a nice start.
Thank you, @williamhyun. Lines 354 to 358 in edccbd8
The original size of the image is 475 * 175 px. |
How about getting the asf logo size to autoscale to the resolution at a small resolution. I replaced L354-358 with the code below and it looks good. img {
margin: -30px 0 0;
object-fit: contain;
max-width: 100%;
max-height: 100%;
width: auto;
height: auto;
} |
|
To @guiyanakuang , when I tried your patch. The ratio is good but it's overflew still. |
site/README.md
Outdated
|
||
## Browsing | ||
|
||
Look at the site by navigating to | ||
[http://0.0.0.0:4000/](http://0.0.0.0:4000/) . | ||
[http://localhost:4000/](http://localhost:4000/) . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, let's revert this part.
Since the Apache Logo distortion is one of the old website issue, let's handle them separately. Let me merge this first to help William move forward further. |
### What changes were proposed in this pull request? This PR aims to revamp the ORC website. ### Why are the changes needed? To improve the followings: - Increase page width and improve resizing - Create `RELEASES` menu - Menu reordering - Improve mobile device UX - Fix the broken layout in the footer ### How was this patch tested? I tested with various resolutions listed below. <img width="997" alt="Screen Shot 2022-08-09 at 9 03 23 PM" src="https://user-images.githubusercontent.com/62487364/183810659-3b6fc502-fded-4b73-a7b6-f2aba3fbc1bc.png"> Closes #1197 Closes #1217 from williamhyun/revampwebsite. Lead-authored-by: William Hyun <william@apache.org> Co-authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit f56fbaf) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Merged to main/1.8. Thank you, @williamhyun and @guiyanakuang . |
Oh, it seems that Jekyll is working differently from Apache ORC website serving. |
### What changes were proposed in this pull request? This PR aims to revamp the ORC website. ### Why are the changes needed? To improve the followings: - Increase page width and improve resizing - Create `RELEASES` menu - Menu reordering - Improve mobile device UX - Fix the broken layout in the footer ### How was this patch tested? I tested with various resolutions listed below. <img width="997" alt="Screen Shot 2022-08-09 at 9 03 23 PM" src="https://user-images.githubusercontent.com/62487364/183810659-3b6fc502-fded-4b73-a7b6-f2aba3fbc1bc.png"> Closes apache#1197 Closes apache#1217 from williamhyun/revampwebsite. Lead-authored-by: William Hyun <william@apache.org> Co-authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
What changes were proposed in this pull request?
This PR aims to revamp the ORC website.
Why are the changes needed?
To improve the followings:
RELEASES
menuHow was this patch tested?
I tested with various resolutions listed below.
![Screen Shot 2022-08-09 at 9 03 23 PM](https://user-images.githubusercontent.com/62487364/183810659-3b6fc502-fded-4b73-a7b6-f2aba3fbc1bc.png)
Closes #1197