Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1246: Revamp ORC website #1217

Closed
wants to merge 2 commits into from

Conversation

williamhyun
Copy link
Member

@williamhyun williamhyun commented Aug 10, 2022

What changes were proposed in this pull request?

This PR aims to revamp the ORC website.

Why are the changes needed?

To improve the followings:

  • Increase page width and improve resizing
  • Create RELEASES menu
  • Menu reordering
  • Improve mobile device UX
  • Fix the broken layout in the footer

How was this patch tested?

I tested with various resolutions listed below.
Screen Shot 2022-08-09 at 9 03 23 PM

Closes #1197

@github-actions github-actions bot added the DOCS label Aug 10, 2022
@williamhyun
Copy link
Member Author

williamhyun commented Aug 10, 2022

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @williamhyun . This is a nice start.

@guiyanakuang
Copy link
Member

Thank you, @williamhyun.
I tested at small resolutions and the aspect ratio of the asf logo looks incorrect.
image

orc/site/css/screen.scss

Lines 354 to 358 in edccbd8

img {
margin: -30px 0 0;
width: 180px;
height: 150px;
}

The original size of the image is 475 * 175 px.

@guiyanakuang
Copy link
Member

How about getting the asf logo size to autoscale to the resolution at a small resolution. I replaced L354-358 with the code below and it looks good.

img {
    margin: -30px 0 0;
    object-fit: contain;
    max-width: 100%;
    max-height: 100%;
    width: auto;
    height: auto;
  }

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Aug 10, 2022

+1 for @guiyanakuang 's comment.

@dongjoon-hyun
Copy link
Member

To @guiyanakuang , when I tried your patch. The ratio is good but it's overflew still.

Screen Shot 2022-08-10 at 12 17 41 PM

site/README.md Outdated

## Browsing

Look at the site by navigating to
[http://0.0.0.0:4000/](http://0.0.0.0:4000/) .
[http://localhost:4000/](http://localhost:4000/) .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, let's revert this part.

@dongjoon-hyun
Copy link
Member

Since the Apache Logo distortion is one of the old website issue, let's handle them separately. Let me merge this first to help William move forward further.

dongjoon-hyun added a commit that referenced this pull request Aug 10, 2022
### What changes were proposed in this pull request?
This PR aims to revamp the ORC website.

### Why are the changes needed?
To improve the followings:
- Increase page width and improve resizing
- Create `RELEASES` menu
- Menu reordering
- Improve mobile device UX
- Fix the broken layout in the footer

### How was this patch tested?
I tested with various resolutions listed below.
<img width="997" alt="Screen Shot 2022-08-09 at 9 03 23 PM" src="https://user-images.githubusercontent.com/62487364/183810659-3b6fc502-fded-4b73-a7b6-f2aba3fbc1bc.png">

Closes #1197

Closes #1217 from williamhyun/revampwebsite.

Lead-authored-by: William Hyun <william@apache.org>
Co-authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit f56fbaf)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun dongjoon-hyun added this to the 1.8.0 milestone Aug 10, 2022
@dongjoon-hyun
Copy link
Member

Merged to main/1.8. Thank you, @williamhyun and @guiyanakuang .

@dongjoon-hyun
Copy link
Member

Oh, it seems that Jekyll is working differently from Apache ORC website serving.
After I published, I realized that the Release link is not working while Jekyll serves it well.
Let me take a look at it.

cxzl25 pushed a commit to cxzl25/orc that referenced this pull request Jan 11, 2024
### What changes were proposed in this pull request?
This PR aims to revamp the ORC website.

### Why are the changes needed?
To improve the followings:
- Increase page width and improve resizing
- Create `RELEASES` menu
- Menu reordering
- Improve mobile device UX
- Fix the broken layout in the footer

### How was this patch tested?
I tested with various resolutions listed below.
<img width="997" alt="Screen Shot 2022-08-09 at 9 03 23 PM" src="https://user-images.githubusercontent.com/62487364/183810659-3b6fc502-fded-4b73-a7b6-f2aba3fbc1bc.png">

Closes apache#1197

Closes apache#1217 from williamhyun/revampwebsite.

Lead-authored-by: William Hyun <william@apache.org>
Co-authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apache ORC website revamp
3 participants