ORC-212 ORC-213 Fix timestamp pattern and added new test #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omalley
requested changes
Jun 20, 2017
| @@ -58,7 +58,7 @@ | |||
| private static final Pattern TIMESTAMP_PATTERN = | |||
| Pattern.compile("^[\"]?([0-9]{4}[-/][0-9]{2}[-/][0-9]{2})[T ]" + | |||
| "([0-9]{2}:[0-9]{2}:[0-9]{2})" + | |||
| "(([ ][-+]?[0-9]{2}([:][0-9]{2})?)|Z)?[\"]?$"); | |||
| "(([ ]?[-+]?[0-9]{2}([:][0-9]{2})?)|Z)?[\"]?$"); | |||
There was a problem hiding this comment.
I'd propose that this should be "( [-+]?|[-+])" instead of "[ ]?[-+]?". It doesn't seem right to accept
"2016-12-30T12:34:5608"
There was a problem hiding this comment.
@omalley Good catch. Let me tweak this!
Convert timestamp with timezone to correct UTC time.
|
Can you please create a jira for this issue? Thanks! http://orc.apache.org/bugs |
spasam
changed the title
asfgit
pushed a commit
that referenced
this pull request
Jul 24, 2017
Fixes #130 Signed-off-by: Owen O'Malley <omalley@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ORC-212: JSON convert should properly convert Timestamp string to java.sql.Timestamp
ORC-213: Fix Timestamp regex in JsonSchemaFinder