ORC-1323: Make docker/reinit.sh support target OS arguments
#1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
docker/reinit.sh support target OS arguments
|
Could you review this PR, @williamhyun ? |
williamhyun
pushed a commit
that referenced
this pull request
Dec 1, 2022
### What changes were proposed in this pull request? This PR aims to support target OS arguments in `docker/reinit.sh`. ### Why are the changes needed? Currently, it re-generates all Ones. ### How was this patch tested? Manually. ``` $ cd docker $ ./reinit.sh centos7 Target: centos7 Re-initialize apache/orc-dev:centos7 ... $ ./reinit.sh centos7 ubuntu22 Target: centos7 ubuntu22 Re-initialize apache/orc-dev:centos7 ... $ ./reinit.sh Target: centos7 debian10 debian11 ubuntu18 ubuntu20 ubuntu22 fedora37 debian10_jdk=11 ubuntu20_jdk=11 ubuntu20_jdk=11_cc=clang Re-initialize apache/orc-dev:centos7 ... ``` Closes #1330 from dongjoon-hyun/ORC-1323. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: William Hyun <william@apache.org> (cherry picked from commit 3870ecd) Signed-off-by: William Hyun <william@apache.org>
|
Thank you, @williamhyun . |
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 6, 2023
### What changes were proposed in this pull request? This PR aims to support target OS arguments in `docker/reinit.sh`. ### Why are the changes needed? Currently, it re-generates all Ones. ### How was this patch tested? Manually. ``` $ cd docker $ ./reinit.sh centos7 Target: centos7 Re-initialize apache/orc-dev:centos7 ... $ ./reinit.sh centos7 ubuntu22 Target: centos7 ubuntu22 Re-initialize apache/orc-dev:centos7 ... $ ./reinit.sh Target: centos7 debian10 debian11 ubuntu18 ubuntu20 ubuntu22 fedora37 debian10_jdk=11 ubuntu20_jdk=11 ubuntu20_jdk=11_cc=clang Re-initialize apache/orc-dev:centos7 ... ``` Closes #1330 from dongjoon-hyun/ORC-1323. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: William Hyun <william@apache.org> (cherry picked from commit 3870ecd) Signed-off-by: William Hyun <william@apache.org> (cherry picked from commit 4cf4e87) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
I backported this test PR to branch-1.7 too. |
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? This PR aims to support target OS arguments in `docker/reinit.sh`. ### Why are the changes needed? Currently, it re-generates all Ones. ### How was this patch tested? Manually. ``` $ cd docker $ ./reinit.sh centos7 Target: centos7 Re-initialize apache/orc-dev:centos7 ... $ ./reinit.sh centos7 ubuntu22 Target: centos7 ubuntu22 Re-initialize apache/orc-dev:centos7 ... $ ./reinit.sh Target: centos7 debian10 debian11 ubuntu18 ubuntu20 ubuntu22 fedora37 debian10_jdk=11 ubuntu20_jdk=11 ubuntu20_jdk=11_cc=clang Re-initialize apache/orc-dev:centos7 ... ``` Closes apache#1330 from dongjoon-hyun/ORC-1323. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: William Hyun <william@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support target OS arguments in
docker/reinit.sh.Why are the changes needed?
Currently, it re-generates all Ones.
How was this patch tested?
Manually.