ORC-1345: Use makeBom and skip snapshot check in GitHub Action publish_snapshot job
#1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
publish_snapshot jobpublish_snapshot job
dongjoon-hyun
changed the title
publish_snapshot jobmakeBom and skip snapshot check in GitHub Action publish_snapshot job
|
This is tested manually, but should be verified after merging. Let me merge this. |
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 7, 2023
…lish_snapshot` job ### What changes were proposed in this pull request? This PR aims to improve GitHub Action `publish_snapshot` job by using `makeBom` and skipping checking snapshot versions. In addition, the download transfer progress is also disabled to reduce the log size. ### Why are the changes needed? `publish_snapshot` is always generating new set of snapshot files. ### How was this patch tested? Manual review. This should be verified after merging. https://github.com/apache/orc/blob/eee67e192017ee78fa89061ffc8a013c0daf14c7/.github/workflows/publish_snapshot.yml#L3-L6 Closes #1355 from dongjoon-hyun/ORC-1345. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 93b76cb) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 7, 2023
…lish_snapshot` job ### What changes were proposed in this pull request? This PR aims to improve GitHub Action `publish_snapshot` job by using `makeBom` and skipping checking snapshot versions. In addition, the download transfer progress is also disabled to reduce the log size. ### Why are the changes needed? `publish_snapshot` is always generating new set of snapshot files. ### How was this patch tested? Manual review. This should be verified after merging. https://github.com/apache/orc/blob/eee67e192017ee78fa89061ffc8a013c0daf14c7/.github/workflows/publish_snapshot.yml#L3-L6 Closes #1355 from dongjoon-hyun/ORC-1345. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 93b76cb) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
…lish_snapshot` job ### What changes were proposed in this pull request? This PR aims to improve GitHub Action `publish_snapshot` job by using `makeBom` and skipping checking snapshot versions. In addition, the download transfer progress is also disabled to reduce the log size. ### Why are the changes needed? `publish_snapshot` is always generating new set of snapshot files. ### How was this patch tested? Manual review. This should be verified after merging. https://github.com/apache/orc/blob/eee67e192017ee78fa89061ffc8a013c0daf14c7/.github/workflows/publish_snapshot.yml#L3-L6 Closes apache#1355 from dongjoon-hyun/ORC-1345. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to improve GitHub Action
publish_snapshotjob by usingmakeBomand skipping checking snapshot versions. In addition, the download transfer progress is also disabled to reduce the log size.Why are the changes needed?
publish_snapshotis always generating new set of snapshot files.How was this patch tested?
Manual review. This should be verified after merging.
orc/.github/workflows/publish_snapshot.yml
Lines 3 to 6 in eee67e1