ORC-1349: [C++] remove useless bufStream definition #1360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `TestByteRLEEncoder.cc`, bufStream was defined but not used, so remove those useless definitions. Signed-off-by: Junwang Zhao <zhjwpku@gmail.com>
wgtmac
approved these changes
Jan 9, 2023
Yes, all unused. The unique_ptr |
dongjoon-hyun
approved these changes
Jan 9, 2023
|
Merged to main for Apache ORC 1.9.0 |
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? In `TestByteRLEEncoder.cc`, bufStream was defined but not used, so remove those useless definitions. ### Why are the changes needed? the definitions are useless. ### How was this patch tested? It doesn't introduce new features and passed all test cases. Closes apache#1360 from zhjwpku/remove_useless_bufstream. Authored-by: Junwang Zhao <zhjwpku@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
TestByteRLEEncoder.cc, bufStream was defined but not used, so remove those useless definitions.Why are the changes needed?
the definitions are useless.
How was this patch tested?
It doesn't introduce new features and passed all test cases.