ORC-1395: Enforce license check via github action #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
force-pushed
the
upstream/branch-1.7
branch
from
8cffe3d
to
84f14ba
Compare
dongjoon-hyun
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
+1, LGTM (Pending CIs).
Could you re-trigger the failed pipeline, @wgtmac ?
Add a Gitbub action to enforce license check of c++ source files. apache#1427 was accidentally merged without license headers added to new files. We need a tool to automatically check it before merging. Make sure the new action works as expected. Closes apache#1442 from wgtmac/license. Authored-by: Gang Wu <ustcwg@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
wgtmac
force-pushed
the
upstream/branch-1.7
branch
from
84f14ba
to
7612947
Compare
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Gitbub action to enforce license check of c++ source files.
#1427 was accidentally merged without license headers added to new files. We need a tool to automatically check it before merging.
Make sure the new action works as expected.
Closes #1442 from wgtmac/license.
Authored-by: Gang Wu ustcwg@gmail.com