-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORC-1471: Updated README.md to use maven 3.8.8 #1571
Conversation
Public signup for JIRA is disabled, hence cannot create a JIRA account |
You can apply for a Jira account on this page(https://selfserve.apache.org/jira-account.html). |
New Jira user account, has been created -- thanks for the PR @mystic-lama |
Thank you, @mystic-lama , @guiyanakuang , @pgaref . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the Apache ORC community, @mystic-lama .
I created ORC-1471 and assigned it to you. You are added to the Apache ORC contributor group too.
Congratulation for your first contribution.
Thank you!
### What changes were proposed in this pull request? The PR proposes to update README to reflect the actual maven version to be used for build. Current documentations says Maven version 3.8.6 or higher. However, the build fails with Maven 3.8.6 with error ``` [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.3.0:enforce (enforce-maven) on project orc: [ERROR] Rule 0: org.apache.maven.enforcer.rules.version.RequireMavenVersion failed with message: [ERROR] Detected Maven Version: 3.8.6 is not in the allowed range [3.8.8,). ``` ### Why are the changes needed? The changes are need to keep documentation in sync with maven version used for build. ### How was this patch tested? Documentation patch, no tests were done Closes apache#1571 from mystic-lama/doc_maven_version_fix. Authored-by: mystic-lama <mysticlama000@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
What changes were proposed in this pull request?
The PR proposes to update README to reflect the actual maven version to be used for build.
Current documentations says Maven version 3.8.6 or higher. However, the build fails with Maven 3.8.6 with error
Why are the changes needed?
The changes are need to keep documentation in sync with maven version used for build.
How was this patch tested?
Documentation patch, no tests were done