Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1599: Add zstd compression level and windowlog in Java configuration documentation #1766

Closed
wants to merge 1 commit into from

Conversation

cxzl25
Copy link
Contributor

@cxzl25 cxzl25 commented Jan 22, 2024

What changes were proposed in this pull request?

Added documentation about orc.compression.zstd.level orc.compression.zstd.windowlog configuration.
(ORC-817, ORC-1088 2.0.0)

Why are the changes needed?

How was this patch tested?

GA

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the DOCS label Jan 22, 2024
@dongjoon-hyun dongjoon-hyun added this to the 2.0.0 milestone Jan 22, 2024
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revise the PR title by adding Java Config. Otherwise, the JIRA and PR title will mislead the Spark and Hive users.

@cxzl25 cxzl25 changed the title ORC-1599: Add zstd compression level and windowlog documentation ORC-1599: Add zstd compression level and windowlog in Java configuration documentation Jan 22, 2024
@cxzl25
Copy link
Contributor Author

cxzl25 commented Jan 22, 2024

Please revise the PR title by adding Java Config

Done. Thanks @dongjoon-hyun .

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @cxzl25 .

dongjoon-hyun pushed a commit that referenced this pull request Jan 22, 2024
…ion documentation

### What changes were proposed in this pull request?
Added documentation about `orc.compression.zstd.level` `orc.compression.zstd.windowlog` configuration.
(ORC-817, ORC-1088 2.0.0)

### Why are the changes needed?

### How was this patch tested?
GA

### Was this patch authored or co-authored using generative AI tooling?
No

Closes #1766 from cxzl25/ORC-1599.

Authored-by: sychen <sychen@ctrip.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit d71f407)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants