ORC-1631: Support summary output in sizes command
#1816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
summary output in sizes command
dongjoon-hyun
approved these changes
Feb 26, 2024
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 26, 2024
### What changes were proposed in this pull request?
Add support for summarizing the number of files, file sizes and file lines in the sizes command.
### Why are the changes needed?
When we count the size of each field, we only know the percentage and the average size of each row, but we do not know the overall value.
### How was this patch tested?
local test
```bash
java -jar orc-tools-2.1.0-SNAPSHOT-uber.jar sizes -h
usage: sizes
-h,--help Print help message
-i,--ignoreExtension Ignore ORC file extension
-s,--summary Summarize the number of files, file sizes, and
file rows
```
```
java -jar orc-tools-2.1.0-SNAPSHOT-uber.jar sizes -s
```
```
Total Files: 5
Total Sizes: 4803687270
Total Rows: 39820045
Percent Bytes/Row Name
26.41 31.86
```
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #1816 from cxzl25/ORC-1631.
Authored-by: sychen <sychen@ctrip.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit f46e55a)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add support for summarizing the number of files, file sizes and file lines in the sizes command.
Why are the changes needed?
When we count the size of each field, we only know the percentage and the average size of each row, but we do not know the overall value.
How was this patch tested?
local test
java -jar orc-tools-2.1.0-SNAPSHOT-uber.jar sizes -h usage: sizes -h,--help Print help message -i,--ignoreExtension Ignore ORC file extension -s,--summary Summarize the number of files, file sizes, and file rowsWas this patch authored or co-authored using generative AI tooling?
No