-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORC-1634: Fix some outdated descriptions in Building ORC
documentation
#1819
Conversation
* [Debian 11]({{ page.dockerUrl }}/debian11/Dockerfile) | ||
* [Debian 12]({{ page.dockerUrl }}/debian12/Dockerfile) | ||
* [Ubuntu 20]({{ page.dockerUrl }}/ubuntu20/Dockerfile) | ||
* [Ubuntu 22]({{ page.dockerUrl }}/ubuntu22/Dockerfile) | ||
* [Ubuntu 24]({{ page.dockerUrl }}/ubuntu24/Dockerfile) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this is still outdated. oraclelinux9
? Where did you reference when you make this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I originally wanted to link this URL https://github.com/apache/orc/blob/main/docker/os-list.txt directly in the document, but now I have completed all OS in the document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, this is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, there is a reason why we don't update this still.
We publish Apache ORC website from main
branch.
So, we cannot publish this until Apache ORC 2.0 is released, @cxzl25 .
Instead, let's update this PR and keep it open until Apache ORC 2.0 is released.
Thanks, looking forward to the Apache ORC 2.0 release. |
Hi @dongjoon-hyun Shall we consider controlling versions we maintance on the UI instead of just pushing master to website? |
Now, it's announced. We can proceed this, @cxzl25 . |
For the above, it's possible but it's a major restructuring.
You can initiate the discussion at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
This is published to the Apache ORC website. Thank you! |
What changes were proposed in this pull request?
Why are the changes needed?
Some outdated descriptions in
Building ORC
documentation.How was this patch tested?
manual check
Was this patch authored or co-authored using generative AI tooling?
No