Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1634: Fix some outdated descriptions in Building ORC documentation #1819

Closed
wants to merge 2 commits into from

Conversation

cxzl25
Copy link
Contributor

@cxzl25 cxzl25 commented Feb 26, 2024

What changes were proposed in this pull request?

  1. Require Java >=17
  2. Remove broken url

Why are the changes needed?

Some outdated descriptions in Building ORC documentation.

How was this patch tested?

manual check

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the DOCS label Feb 26, 2024
* [Debian 11]({{ page.dockerUrl }}/debian11/Dockerfile)
* [Debian 12]({{ page.dockerUrl }}/debian12/Dockerfile)
* [Ubuntu 20]({{ page.dockerUrl }}/ubuntu20/Dockerfile)
* [Ubuntu 22]({{ page.dockerUrl }}/ubuntu22/Dockerfile)
* [Ubuntu 24]({{ page.dockerUrl }}/ubuntu24/Dockerfile)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is still outdated. oraclelinux9? Where did you reference when you make this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I originally wanted to link this URL https://github.com/apache/orc/blob/main/docker/os-list.txt directly in the document, but now I have completed all OS in the document.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, this is good.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there is a reason why we don't update this still.

We publish Apache ORC website from main branch.

So, we cannot publish this until Apache ORC 2.0 is released, @cxzl25 .

Instead, let's update this PR and keep it open until Apache ORC 2.0 is released.

@cxzl25
Copy link
Contributor Author

cxzl25 commented Feb 27, 2024

we cannot publish this until Apache ORC 2.0 is released

Thanks, looking forward to the Apache ORC 2.0 release.

@cxzl25 cxzl25 marked this pull request as draft February 27, 2024 02:46
@deshanxiao
Copy link
Contributor

Actually, there is a reason why we don't update this still.

We publish Apache ORC website from main branch.

So, we cannot publish this until Apache ORC 2.0 is released, @cxzl25 .

Instead, let's update this PR and keep it open until Apache ORC 2.0 is released.

Hi @dongjoon-hyun Shall we consider controlling versions we maintance on the UI instead of just pushing master to website?

@dongjoon-hyun
Copy link
Member

Now, it's announced. We can proceed this, @cxzl25 .

@dongjoon-hyun
Copy link
Member

Shall we consider controlling versions we maintance on the UI instead of just pushing master to website?

For the above, it's possible but it's a major restructuring.

  1. At least, it requires to regenerate all versions' documentation and publish into the ORC website.
  2. We need to split (and redesign) Apache ORC website structure into two groups: one is a main unchanged part and other others in the newly created versioned directory.

You can initiate the discussion at dev@orc mailing list, @cxzl25 .

@cxzl25 cxzl25 marked this pull request as ready for review March 9, 2024 02:11
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@dongjoon-hyun dongjoon-hyun added this to the 2.1.0 milestone Mar 11, 2024
@dongjoon-hyun
Copy link
Member

This is published to the Apache ORC website. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants