ORC-1644: Add merge tool to merge multiple ORC files into a single ORC file
#1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxzl25
changed the title
merge tool to merges multiple ORC files to produce a single ORC file
dongjoon-hyun
changed the title
merge tool to merges multiple ORC files to produce a single ORC filemerge tool to merge multiple ORC files into a single ORC file
williamhyun
approved these changes
Mar 10, 2024
There was a problem hiding this comment.
+1 LGTM
Thank you @cxzl25 @dongjoon-hyun, I will be merging to main and 2.0 for Apache ORC 2.0.1
williamhyun
pushed a commit
that referenced
this pull request
Mar 10, 2024
…ORC file ### What changes were proposed in this pull request? This PR aims to add merge tool to merges multiple ORC files to produce a single ORC file. ### Why are the changes needed? In the ORC 1.3.0 version, the `OrcFile#mergeFiles` method was introduced by [ORC-132](https://issues.apache.org/jira/browse/ORC-132) , which supports merging multiple ORC files into one ORC file. However, when merging, we need to write Java code to call it. There is no simple command that can be called directly. ### How was this patch tested? Add UT ### Was this patch authored or co-authored using generative AI tooling? No Closes #1834 from cxzl25/ORC-1644. Authored-by: sychen <sychen@ctrip.com> Signed-off-by: William Hyun <william@apache.org> (cherry picked from commit b031d37) Signed-off-by: William Hyun <william@apache.org>
|
Thank you, @williamhyun . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add merge tool to merges multiple ORC files to produce a single ORC file.
Why are the changes needed?
In the ORC 1.3.0 version, the
OrcFile#mergeFilesmethod was introduced by ORC-132 , which supports merging multiple ORC files into one ORC file.However, when merging, we need to write Java code to call it.
There is no simple command that can be called directly.
How was this patch tested?
Add UT
Was this patch authored or co-authored using generative AI tooling?
No