Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1648: Add test to convert ORC in the convert command #1839

Closed
wants to merge 2 commits into from

Conversation

cxzl25
Copy link
Contributor

@cxzl25 cxzl25 commented Mar 6, 2024

What changes were proposed in this pull request?

This PR aims to add test to convert ORC in the convert command.

Why are the changes needed?

The convert command supports converting multiple ORCs to a new ORC, such as switching the new ORC compression format.
Improve code test coverage and avoid regressions.

How was this patch tested?

Add UT

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the JAVA label Mar 6, 2024
Copy link
Member

@williamhyun williamhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@williamhyun williamhyun added this to the 2.0.1 milestone Mar 10, 2024
williamhyun pushed a commit that referenced this pull request Mar 10, 2024
### What changes were proposed in this pull request?
This PR aims to add test to convert ORC in the `convert` command.

### Why are the changes needed?
The convert command supports converting multiple ORCs to a new ORC, such as switching the new ORC compression format.
Improve code test coverage and avoid regressions.

### How was this patch tested?
Add UT

### Was this patch authored or co-authored using generative AI tooling?
No

Closes #1839 from cxzl25/ORC-1648.

Authored-by: sychen <sychen@ctrip.com>
Signed-off-by: William Hyun <william@apache.org>
(cherry picked from commit 835d2c2)
Signed-off-by: William Hyun <william@apache.org>
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants