ORC-1667: Add check tool to check the index of the specified column
#1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
site/_docs/java-tools.md
Outdated
| @@ -11,6 +11,7 @@ supports both the local file system and HDFS. | |||
|
|
|||
| The subcommands for the tools are: | |||
|
|
|||
| * bloom-filter (since ORC 2.1) - check the bloom filter of the specified column | |||
There was a problem hiding this comment.
- Since we can backport
toolsmodule patch, let's change this toORC 2.0.1. - The command name,
bloom-filter, is a little ambiguous. Could you provide more intuitive name?
There was a problem hiding this comment.
let's change this to ORC 2.0.1.
OK
The command name, bloom-filter, is a little ambiguous.
How about using check-bloom-filter?
There was a problem hiding this comment.
Sounds better to me for this context.
BTW, if you have more plan to extend this commend, you can use check as subcommand or argument, too.
There was a problem hiding this comment.
Thank you very much for your suggestion.
Let us use the check command. Based on this, we can add min and max statistics to check later.
cxzl25
changed the title
bloom-filter tool to check the bloom filter of the specified columncheck tool to check the index of the specified column
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 29, 2024
### What changes were proposed in this pull request? This PR aims to check the index of the specified column. We can test the filtering effect by specifying different types. `check --type stat` - Only use column statistics. `check --type bloom-filter` - Only use bloom filter. `check --type predicate` - Used in combination with column statistics and bloom filter. ### Why are the changes needed? ORC supports specifying multiple columns to generate bloom filter indexes, but it lacks a convenient tool to verify the effect of bloom filter. Parquet also has similar commands. [PARQUET-2138](https://issues.apache.org/jira/browse/PARQUET-2138): Add ShowBloomFilterCommand to parquet-cli ### How was this patch tested? Add UT ### Was this patch authored or co-authored using generative AI tooling? No Closes #1862 from cxzl25/ORC-1667. Authored-by: sychen <sychen@ctrip.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 3b5b2a6) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to check the index of the specified column.
We can test the filtering effect by specifying different types.
check --type stat- Only use column statistics.check --type bloom-filter- Only use bloom filter.check --type predicate- Used in combination with column statistics and bloom filter.Why are the changes needed?
ORC supports specifying multiple columns to generate bloom filter indexes, but it lacks a convenient tool to verify the effect of bloom filter.
Parquet also has similar commands.
PARQUET-2138: Add ShowBloomFilterCommand to parquet-cli
How was this patch tested?
Add UT
Was this patch authored or co-authored using generative AI tooling?
No