Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump commons-cli:commons-cli from 1.6.0 to 1.7.0 in /java #1906

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 22, 2024

Bumps commons-cli:commons-cli from 1.6.0 to 1.7.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps commons-cli:commons-cli from 1.6.0 to 1.7.0.

---
updated-dependencies:
- dependency-name: commons-cli:commons-cli
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 22, 2024
@cxzl25
Copy link
Contributor

cxzl25 commented Apr 23, 2024

Fix compilation failure via #1907

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 24, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dongjoon-hyun pushed a commit that referenced this pull request Apr 24, 2024
### What changes were proposed in this pull request?
This PR aims to upgrade `commons-cli` to 1.7.0.

### Why are the changes needed?
Release 1.7.0 – 2024-04-13

https://commons.apache.org/proper/commons-cli/changes-report.html#a1.7.0

The default value of `getOptionValue` is null. After upgrading to 1.7.0, a new method was introduced, causing compilation to fail.

```java
this.bloomFilterColumns = opts.getOptionValue('b', null);
```

```
Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project orc-tools: Compilation failure
Error:  /root/orc/java/tools/src/java/org/apache/orc/tools/convert/ConvertTool.java:[202,35] reference to getOptionValue is ambiguous
Error:    both method getOptionValue(char,java.lang.String) in org.apache.commons.cli.CommandLine and method getOptionValue(char,java.util.function.Supplier<java.lang.String>) in org.apache.commons.cli.CommandLine match
```

### How was this patch tested?
GA

### Was this patch authored or co-authored using generative AI tooling?
No

Closes #1906

Closes #1907 from cxzl25/ORC-1698.

Authored-by: sychen <sychen@ctrip.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 67b24ba)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dependabot dependabot bot deleted the dependabot/maven/java/commons-cli-commons-cli-1.7.0 branch April 24, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUILD dependencies Pull requests that update a dependency file JAVA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant