Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-360. Add Java error checking on the types when reading. #266

Merged
merged 1 commit into from May 7, 2018

Conversation

omalley
Copy link
Contributor

@omalley omalley commented May 7, 2018

This patch adds a check on the types in the footer to ensure that the type is properly formed before we start building the tree.

omalley added a commit to omalley/orc that referenced this pull request May 7, 2018
Fixes apache#266

Signed-off-by: Owen O'Malley <omalley@apache.org>
Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

omalley added a commit to omalley/orc that referenced this pull request May 7, 2018
Fixes apache#266

Signed-off-by: Owen O'Malley <omalley@apache.org>
Fixes apache#266

Signed-off-by: Owen O'Malley <omalley@apache.org>
@asfgit asfgit merged commit f47cbe9 into apache:master May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants