ORC-52. Create ORC InputFormat and OutputFormat implementations for org.apache.hadoop.mapreduce API #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omalley
force-pushed
the
orc-52
branch
4 times, most recently
from
78de632
to
d64d724
Compare
| Reader.Options options = new Reader.Options() | ||
| .range(split.getStart(), split.getLength()) | ||
| .useZeroCopy(OrcConf.USE_ZEROCOPY.getBoolean(conf)) | ||
| .skipCorruptRecords(OrcConf.SKIP_CORRUPT_DATA.getBoolean(conf)); |
There was a problem hiding this comment.
These two lines seem to duplicate logic in RecordReaderImpl:
. As far as I can see that's the only reason conf is passed at all. It could be cleaner if Reader.Options's constructor pulled the requisite values from the conf and only stored/exposed those.There was a problem hiding this comment.
Yeah, let me figure out how to merge the common code.
|
LGTM. The new names are helpful. |
omalley
force-pushed
the
orc-52
branch
3 times, most recently
from
8f0fb18
to
ad16a8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.