ORC-589: [C++] add checks about negative dictionary entry lengths #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library used to have a check for negative dictionary entry lengths. However we don't have it on current master. It causes a problem because it will use a negative value (casted to unsigned) to allocate a DataBuffer. This commit adds the missing check. Testing * added a corrupt orc file and a unit test
wgtmac
reviewed
Jan 14, 2020
c++/src/ColumnReader.cc
Outdated
| @@ -581,6 +581,8 @@ namespace orc { | |||
| lengthDecoder->next(lengthArray + 1, dictSize, nullptr); | |||
| lengthArray[0] = 0; | |||
| for(uint32_t i = 1; i < dictSize + 1; ++i) { | |||
| if (lengthArray[i] < 0) | |||
There was a problem hiding this comment.
Please add curly brace here even for a single line if-statement.
c++/test/TestCorruptFiles.cc
Outdated
| namespace orc { | ||
|
|
||
| TEST(TestCorruptFiles, testNegativeDictEntryLengths) { | ||
|
|
stiga-huang
reviewed
Jan 14, 2020
c++/test/TestCorruptFiles.cc
Outdated
|
|
||
| namespace orc { | ||
|
|
||
| TEST(TestCorruptFiles, testNegativeDictEntryLengths) { |
There was a problem hiding this comment.
I think moving this into TestFileScan.testErrorHandling in TestFileScan.cc is simpler.
stiga-huang
pushed a commit
to stiga-huang/orc
that referenced
this pull request
Jan 18, 2020
The library used to have a check for negative dictionary entry lengths. However we don't have it on current master. It causes a problem because it will use a negative value (casted to unsigned) to allocate a DataBuffer. This commit adds the missing check. This fixes apache#468
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library used to have a check for negative dictionary entry lengths.
However we don't have it on current master. It causes a problem because
it will use a negative value (casted to unsigned) to allocate a
DataBuffer. This commit adds the missing check.
Testing