Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-628. Add tool to count number of rows in ORC files under a directory #506

Merged
merged 1 commit into from May 7, 2020

Conversation

omalley
Copy link
Contributor

@omalley omalley commented May 6, 2020

No description provided.

@@ -116,6 +116,8 @@ public static void main(String[] args) throws Exception {
ConvertTool.main(conf, options.commandArgs);
} else if ("key".equals(options.command)) {
KeyTool.main(conf, options.commandArgs);
} else if ("count".equals(options.command)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a description for count command after line 95?

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented May 7, 2020

I found that orc-tools uber jar has been broken due to ORC-599 and made a PR to fix it. Could you review that, please?

@omalley
Copy link
Contributor Author

omalley commented May 7, 2020

Sorry about that! I wrote and tested the patch on branch 1.5, so it worked. Thanks for fixing master.

…ory.

Fixes apache#506

Signed-off-by: Owen O'Malley <omalley@apache.org>
@omalley omalley merged commit 78e9975 into apache:master May 7, 2020
@dongjoon-hyun
Copy link
Member

Thank you, @omalley .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants