Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-689: Add GitHubAction job to publish snapshot #573

Merged
merged 1 commit into from Nov 29, 2020
Merged

ORC-689: Add GitHubAction job to publish snapshot #573

merged 1 commit into from Nov 29, 2020

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Nov 28, 2020

What changes were proposed in this pull request?

This PR aims to add GitHub Action job to publish snapshot like the following. The following is generated by this patch from my fork master branch.

Why are the changes needed?

Currently, Apache ORC community doesn't provide snapshot artifacts. It would be great if we provide it in order to help the downstream projects to test it in advance.

How was this patch tested?

This is tested in my ORC fork and we need INFRA team's credential setup.

@dongjoon-hyun dongjoon-hyun changed the title ORC-689. Add GitHubAction job to publish snapshot ORC-689: Add GitHubAction job to publish snapshot Nov 28, 2020
@dongjoon-hyun
Copy link
Member Author

Could you review this PR, @pgaref and @omalley ?

@pgaref
Copy link
Contributor

pgaref commented Nov 29, 2020

Pretty useful stuff !
@dongjoon-hyun did you check snapshots are actually overwritten every time? Would it make sense to keep some kind of history (the last 5 commits)?

Also seems that we could do it for multiple branches (e.g., 1.5, 1.6) : https://github.com/apache/orc/pull/573/files#diff-29a5e74df281c9ad42f5916e4f9d6de35f6e3efc2a0e86576bea5235c0a0f1edR6

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Nov 29, 2020

Thank you for review, @pgaref .

It's not overwritten. Maven snapshot publishing uses a timestamp postfix. Please see https://repository.apache.org/content/repositories/snapshots/org/apache/orc/orc-core/1.7.0-SNAPSHOT/

did you check snapshots are actually overwritten every time? Would it make sense to keep some kind of history (the last 5 commits)?

The target branch will be updated during manual backporting like we did for the other action job.

Also seems that we could do it for multiple branches (e.g., 1.5, 1.6) :

@dongjoon-hyun
Copy link
Member Author

BTW, the INFRA change should be tested after we merge this on master branch. After master branch verification, I will backport to branch-1.6 and branch-1.5.

@dongjoon-hyun dongjoon-hyun merged commit 507a03e into apache:master Nov 29, 2020
@dongjoon-hyun
Copy link
Member Author

Thank you, @pgaref . I'll merge this and adjust according to Apache INFRA team's setup.

@dongjoon-hyun dongjoon-hyun deleted the ORC-689-2 branch November 29, 2020 19:20
dongjoon-hyun added a commit that referenced this pull request Dec 3, 2020
This PR aims to add `GitHub Action` job to publish snapshot like the following. The following is generated by this patch from my fork `master` branch.

- https://repository.apache.org/content/repositories/snapshots/org/apache/orc/orc-core/1.7.0-SNAPSHOT/

Currently, Apache ORC community doesn't provide snapshot artifacts. It would be great if we provide it in order to help the downstream projects to test it in advance.

This is tested in my ORC fork and we need INFRA team's credential setup.

- https://github.com/dongjoon-hyun/orc/runs/1468464962 (I merged to my `master` branch and removed it after testing)
- https://issues.apache.org/jira/browse/INFRA-21150 (Upload snapshots from GitHub Actions)

(cherry picked from commit 507a03e)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun
Copy link
Member Author

I backported this to branch-1.6.

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Dec 3, 2020

Apache ORC is now publishing snapshots from my repository, @pgaref . I added the secrets to my repo.

dongjoon-hyun added a commit that referenced this pull request Dec 18, 2020
This PR aims to add `GitHub Action` job to publish snapshot like the following. The following is generated by this patch from my fork `master` branch.

- https://repository.apache.org/content/repositories/snapshots/org/apache/orc/orc-core/1.7.0-SNAPSHOT/

Currently, Apache ORC community doesn't provide snapshot artifacts. It would be great if we provide it in order to help the downstream projects to test it in advance.

This is tested in my ORC fork and we need INFRA team's credential setup.

- https://github.com/dongjoon-hyun/orc/runs/1468464962 (I merged to my `master` branch and removed it after testing)
- https://issues.apache.org/jira/browse/INFRA-21150 (Upload snapshots from GitHub Actions)

(cherry picked from commit a70eb7d)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants