Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORC-699. Minor improvements to the scan tool that make the exception messages optional. #583

Merged
merged 1 commit into from
Dec 19, 2020
Merged

ORC-699. Minor improvements to the scan tool that make the exception messages optional. #583

merged 1 commit into from
Dec 19, 2020

Conversation

omalley
Copy link
Contributor

@omalley omalley commented Dec 15, 2020 •
edited by dongjoon-hyun

What changes were proposed in this pull request?

  • Change the stripe id to be 0 based, which seems more consistent.
  • Change the end of file stripe id to be the number of stripes rather than -1.
  • Limit the recovery row to the start of the next stripe.
  • Add --verbose that prints exceptions.
  • Fix the --help to give more information

How was this patch tested?

Tested by hand on the example files.

@omalley
ORC-699. Minor improvements to the scan tool that make the exception …
64fbe68 
…messages optional.

Signed-off-by: Owen O'Malley <omalley@apache.org>
dongjoon-hyun
dongjoon-hyun approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @omalley . I checked -v option manually.

@dongjoon-hyun dongjoon-hyun merged commit 8d02646 into apache:master Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@omalley @dongjoon-hyun