ORC-734: Use org.apache.commons.lang3 #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @pgaref |
pgaref
approved these changes
Jan 14, 2021
|
Thank you! |
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 14, 2021
### What changes were proposed in this pull request? Although ORC-682 upgraded to `commons-lang3`, we are still using `commons-lang` classes. ### Why are the changes needed? This will switch it completely. ### How was this patch tested? Pass the CIs. These are the all instances. ``` $ git grep org.apache.commons.lang. core/src/java/org/apache/orc/impl/RecordReaderUtils.java:import org.apache.commons.lang3.builder.HashCodeBuilder; core/src/java/org/apache/orc/impl/mask/RedactMaskFactory.java:import org.apache.commons.lang3.StringUtils; core/src/test/org/apache/orc/TestColumnStatistics.java:import org.apache.commons.lang3.RandomStringUtils; core/src/test/org/apache/orc/TestColumnStatistics.java:import org.apache.commons.lang3.StringEscapeUtils; core/src/test/org/apache/orc/TestUnicode.java:import org.apache.commons.lang3.StringUtils; core/src/test/org/apache/orc/impl/TestPredicatePushDownBounds.java:import org.apache.commons.lang3.StringUtils; mapreduce/src/java/org/apache/orc/mapred/OrcInputFormat.java:import org.apache.commons.lang3.StringUtils; tools/src/java/org/apache/orc/tools/FileDump.java:import org.apache.commons.lang3.StringUtils; ``` (cherry picked from commit 50764d0) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Merged to master/branch-1.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Although ORC-682 upgraded to
commons-lang3, we are still usingcommons-langclasses.Why are the changes needed?
This will switch it completely.
How was this patch tested?
Pass the CIs.
These are the all instances.