ORC-750: Fix bench to use orc pom as parent. #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes LGTM - +1 |
This enables the analyze profile. As part of the change, it also fixes the real findbugs warnings and blocks some false positives. Fixes apache#643 Signed-off-by: Owen O'Malley <omalley@apache.org>
|
BTW, do you know why Travis CI is failing? |
|
It looks like it is passing now. https://www.travis-ci.com/github/apache/orc/builds/217427153 |
| <groupId>org.apache.orc</groupId> | ||
| <artifactId>orc</artifactId> | ||
| <version>1.7.0-SNAPSHOT</version> | ||
| <relativePath>../pom.xml</relativePath> |
There was a problem hiding this comment.
This seems to break uber jar building in spark submodule.
$ cd java/bench
$ mvn clean package -pl spark --am
$ ls -alh spark/target/*.jar
-rw-rw-r-- 1 dongjoon dongjoon 62K Mar 23 05:28 spark/target/orc-benchmarks-spark-1.7.0-SNAPSHOT.jar
-rw-rw-r-- 1 dongjoon dongjoon 808K Mar 23 05:28 spark/target/orc-benchmarks-spark-1.7.0-SNAPSHOT-nohive.jar
The correct uber jar should be 129MB.
$ ls -alh spark/target/*.jar
-rw-rw-r-- 1 dongjoon dongjoon 129M Mar 23 05:32 spark/target/orc-benchmarks-spark-1.7.0-SNAPSHOT.jar
-rw-rw-r-- 1 dongjoon dongjoon 63K Mar 23 05:32 spark/target/original-orc-benchmarks-spark-1.7.0-SNAPSHOT.jar
There was a problem hiding this comment.
I'll make a PR to fix this.
|
Here is the PR to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the benchmark pom so that it uses the orc pom as the parent.
That allows us to remove some duplication and means that the analyze profile becomes defined with benchmarks.
With that change, we now run findbugs and checkstyle on benchmark. Thus, we need to fix some findbugs
warnings and disable others.