ORC-758: Avoid seeking and decompressing of compressed stream #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… required seek is already satisfied by the current decompressed block
pavibhai
force-pushed
the
orc_758_seek_fix
branch
from
869ca13
to
7305afe
Compare
omalley
reviewed
Mar 19, 2021
omalley
requested changes
Mar 19, 2021
* Switched position tracking from compressed.position to this.position * Added a new test instead of changing the existing test * Enhanced the test to verify when the stream is initialized with an offset
|
Hey @pavibhai can you please check the remaining comments? |
omalley
reviewed
Mar 22, 2021
omalley
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If the seek on a compressed stream is already satisfied by the current decompression then avoid seeking and decompressing the same block again.
Why are the changes needed?
Seeks performed within the same compression block avoid the costs of decompression.
How was this patch tested?
Modified an existing test to verify that the compressed buffer changes only when the seek is needed and not in other cases.
Additionally all of the existing tests pass.