ORC-763: [C++] Fix ORC timestamp inconsistencies with Java ORC #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgaref
reviewed
Mar 22, 2021
There was a problem hiding this comment.
Thanks for this @wgtmac !
Looks to be consistent with https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java#L1227-L1229
Shall we also add a test with the TS around 1970 as per ticket to check behaviour?
|
Thank you for adding the test case. |
pgaref
approved these changes
Mar 23, 2021
|
Thank you, @dongjoon-hyun and @pgaref . |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 23, 2021
### What changes were proposed in this pull request? The Java ORC reader takes one second off from timestamp values with negative second and nanosecond greater than 999999. The C++ ORC reader/writer should use same logic to be consistent. ### Why are the changes needed? WIthout this fix, we may see data inconsistency of timestamp values from different ORC readers. ### How was this patch tested? It can be tested manually by C++/Java ORC tools. (cherry picked from commit ba45bcc) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
This is backported to branch-1.6, too. |
|
Thanks for the fix @wgtmac ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The Java ORC reader takes one second off from timestamp values with negative second and nanosecond greater than 999999. The C++ ORC reader/writer should use same logic to be consistent.
Why are the changes needed?
WIthout this fix, we may see data inconsistency of timestamp values from different ORC readers.
How was this patch tested?
It can be tested manually by C++/Java ORC tools.