ORC-909: Remove commons-io v2.1 dependency #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
Aug 4, 2021
|
|
||
| /** | ||
| * This is copied from commons-io project to cut the dependency | ||
| * from old Hadoop. |
There was a problem hiding this comment.
|
cc @pgaref and @williamhyun |
pgaref
approved these changes
Aug 4, 2021
|
Thank you so much, @pgaref ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 4, 2021
### What changes were proposed in this pull request? This PR aims to remove `commons-io` v2.1 dependency which comes from `Hadoop 2.2.0`. - https://mvnrepository.com/artifact/org.apache.orc/orc-core/1.6.9 ### Why are the changes needed? This is a hidden dependency due to four lines using a single function `IOUtils.skipFully`. We had better cut this. ``` $ git grep org.apache.commons.io core/src/java/org/apache/orc/impl/RunLengthByteReader.java:import org.apache.commons.io.IOUtils; core/src/java/org/apache/orc/impl/SerializationUtils.java:import org.apache.commons.io.IOUtils; ``` ``` $ git grep IOUtils | grep -v import core/src/java/org/apache/orc/impl/RunLengthByteReader.java: IOUtils.skipFully(input,1); core/src/java/org/apache/orc/impl/RunLengthByteReader.java: IOUtils.skipFully(input, numSkipRows); core/src/java/org/apache/orc/impl/SerializationUtils.java: IOUtils.skipFully(in, numOfFloats * 4L); core/src/java/org/apache/orc/impl/SerializationUtils.java: IOUtils.skipFully(in, numOfDoubles * 8L); ``` ### How was this patch tested? Pass the CIs. (cherry picked from commit a9a5286) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to remove
commons-iov2.1 dependency which comes fromHadoop 2.2.0.Why are the changes needed?
This is a hidden dependency due to four lines using a single function
IOUtils.skipFully. We had better cut this.How was this patch tested?
Pass the CIs.