ORC-937: Replace deprecated method #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude calls to deprecated methods for compatibility or active testing. Replace all deprecated methods with recommended methods.
dongjoon-hyun
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
+1, LGTM. Thank you, @guiyanakuang .
Merged to main for Apache ORC 1.8.
|
Thanks @dongjoon-hyun for a quick review. I am pleased to contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Exclude calls to deprecated methods for compatibility or active testing. Replace all deprecated methods with recommended methods.
org.apache.commons.cli
OptionBuilder -> Option.builder
GnuParser -> DefaultParser
org.apache.parquet.avro
AvroParquetWriter.<GenericData.Record>builder(path) -> AvroParquetWriter.<GenericData.Record>builder(outputFile)
AvroParquetReader.<GenericData.Record>builder(path) -> AvroParquetReader.<GenericData.Record>builder(inputFile)
DateColumnStatistics
getMaximum -> getMaximumLocalDate
getMinimum -> getMinimumLocalDate
hadoop
FSDataOutputStream(OutputStream) -> FSDataOutputStream(OutputStream, FileSystem.Statistics)
fileStatus.isDir -> fileStatus.isDirectory
Why are the changes needed?
Use the recommended method. Possible deprecated methods are removed when dependencies are upgraded.
How was this patch tested?
Pass the CIs