ORC-945: Add OUTPUT_QUIET, ERROR_QUIET to suppress Java8 add-open error messages #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @dongjoon-hyun |
|
Thank you for pinging me, @williamhyun . |
|
I checked that |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 14, 2021
…r messages (#858) ### What changes were proposed in this pull request? This PR aims to add `OUTPUT_QUIET` and `ERROR_QUIET` to suppress Java8 `add-open` error messages ### Why are the changes needed? Error messages could be misleading, so we had better suppress it. - https://github.com/apache/orc/runs/3324055264 ``` Unrecognized option: --add-opens Error: Could not create the Java Virtual Machine. Error: A fatal exception has occurred. Program will exit. ``` ### How was this patch tested? Check the GHA logs on this PR. (cherry picked from commit 6840cd6) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 14, 2021
…r messages (#858) ### What changes were proposed in this pull request? This PR aims to add `OUTPUT_QUIET` and `ERROR_QUIET` to suppress Java8 `add-open` error messages ### Why are the changes needed? Error messages could be misleading, so we had better suppress it. - https://github.com/apache/orc/runs/3324055264 ``` Unrecognized option: --add-opens Error: Could not create the Java Virtual Machine. Error: A fatal exception has occurred. Program will exit. ``` ### How was this patch tested? Check the GHA logs on this PR. (cherry picked from commit 6840cd6) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Merged to main/1.7/1.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add
OUTPUT_QUIETandERROR_QUIETto suppress Java8add-openerror messagesWhy are the changes needed?
Error messages could be misleading, so we had better suppress it.
How was this patch tested?
Check the GHA logs on this PR.