ORC-148: Move ORC PPD failure messages from WARN to DEBUG level #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omalley
reviewed
Mar 4, 2017
| @@ -468,16 +470,15 @@ static TruthValue evaluatePredicateRange(PredicateLeaf predicate, Object min, | |||
| } | |||
| // in case failed conversion, return the default YES_NO_NULL truth value | |||
| } catch (Exception e) { | |||
| if (LOG.isWarnEnabled()) { | |||
| if (LOG.isDebugEnabled()) { | |||
There was a problem hiding this comment.
This isn't ok. We can't take exceptions and make them invisible. We need to avoid the exception.
|
Here's a more complete solution. https://github.com/omalley/orc/tree/orc-148 It will still get 1 log line per a stripe, but that is much better than 1 per a row group. It also downgrades the expected exceptions to info. I considered downgrading it further to debug, |
|
lgtm, +1. |
omalley
added a commit
to omalley/orc
that referenced
this pull request
Apr 25, 2017
Fixes apache#99 Signed-off-by: Owen O'Malley <omalley@apache.org>
omalley
added a commit
to omalley/orc
that referenced
this pull request
Apr 25, 2017
Fixes apache#99 Signed-off-by: Owen O'Malley <omalley@apache.org>
|
I realized that we really shouldn't be using the variable, but rather the sarg leaf as the thing we are caching the exceptional results for. (So that we avoid excessive logging) |
asfgit
pushed a commit
that referenced
this pull request
Apr 25, 2017
Fixes #99 Signed-off-by: Owen O'Malley <omalley@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.