Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-875: Add GitHub Action job for Windows Server 2019 (#872) #999

Merged
merged 1 commit into from Jan 8, 2022
Merged

ORC-875: Add GitHub Action job for Windows Server 2019 (#872) #999

merged 1 commit into from Jan 8, 2022

Conversation

dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This PR aims to add a test coverage for Windows on GitHub Action additionally.

Why are the changes needed?

This PR aims to replace AppVeyor with GitHub Action eventually.

AS IS(AppVeyor)

orc/appveyor.yml

Lines 18 to 41 in ae660f3

environment:
matrix:
- JOB: Visual Studio 2015
CMAKE_GENERATOR: Visual Studio 14 2015
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
platform:
- x64
configuration:
- Debug
build_script:
- mkdir build
- cd build
- if "%platform%"=="x64" set CMAKE_GENERATOR=%CMAKE_GENERATOR% Win64
- cmake .. -G "%CMAKE_GENERATOR%"
-DCMAKE_BUILD_TYPE=%CONFIGURATION%
-DBUILD_CPP_TESTS=ON
-DBUILD_LIBHDFSPP=OFF
-DBUILD_TOOLS=OFF
-DBUILD_JAVA=OFF
- cmake --build . --config %CONFIGURATION%
- ctest -VV -C %CONFIGURATION%

THIS PR(GitHub Action)

https://github.com/apache/orc/runs/4662857757?check_suite_focus=true

-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe - skipped
-- compiler MSVC version 19.0.24245.0
...
Test project D:/a/orc/orc/build
    Start 1: orc-test
1/1 Test #1: orc-test .........................   Passed   61.99 sec

How was this patch tested?

Pass the GitHub Action with newly add Windows job.

### What changes were proposed in this pull request?

This PR aims to add a test coverage for Windows on GitHub Action additionally.

### Why are the changes needed?

This PR aims to replace `AppVeyor` with GitHub Action eventually.

**AS IS(AppVeyor)**

https://github.com/apache/orc/blob/ae660f3006cae145d0db7a897fd81fe94029c0b2/appveyor.yml#L18-L41

**THIS PR(GitHub Action)**

https://github.com/apache/orc/runs/4662857757?check_suite_focus=true

```
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe - skipped
-- compiler MSVC version 19.0.24245.0
...
Test project D:/a/orc/orc/build
    Start 1: orc-test
1/1 Test #1: orc-test .........................   Passed   61.99 sec
```

### How was this patch tested?

Pass the GitHub Action with newly add Windows job.

(cherry picked from commit 2b62dc3)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit b1b0fed)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun
Copy link
Member Author

This is a backport from branch-1.7 to branch-1.6.
Although I usually do cherry-pick manually, I made a PR because this should be tested on GitHub Action Windows runner.

@dongjoon-hyun dongjoon-hyun added this to the 1.6.13 milestone Jan 8, 2022
@dongjoon-hyun
Copy link
Member Author

Build on Windows passed. Merged to branch-1.6.

@dongjoon-hyun dongjoon-hyun merged commit 2cc6f2a into apache:branch-1.6 Jan 8, 2022
@dongjoon-hyun dongjoon-hyun deleted the ORC-875-1.6 branch January 8, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant