review and checkstyle fix

apache · Jan 28, 2020 · 717b0ff · 717b0ff
1 parent e573284
commit 717b0ff
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/...ne-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequest.java b/...ne-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequest.java
@@ -218,7 +218,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
           keyName);
       OmKeyInfo dbKeyInfo = omMetadataManager.getKeyTable().get(ozoneKey);
       if (dbKeyInfo != null) {
-        // Check if this transaction is a replay of ratis logs.
         // Check if this transaction is a replay of ratis logs.
         // We check only the KeyTable here and not the OpenKeyTable. In case
         // this transaction is a replay but the transaction was not committed

diff --git a/...zone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java b/...zone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java
@@ -82,10 +82,16 @@ public abstract class OMKeyRequest extends OMClientRequest {
 
   private static final Logger LOG = LoggerFactory.getLogger(OMKeyRequest.class);
 
+  /**
+   * Stores the result of request execution in
+   * OMClientRequest#validateAndUpdateCache.
+   */
   public enum Result {
-    SUCCESS,
-    REPLAY,
-    FAILURE
+    SUCCESS, // The request was executed successfully
+
+    REPLAY, // The request is a replay and was ignored
+
+    FAILURE // The request failed and exception was thrown
   }
 
   public OMKeyRequest(OMRequest omRequest) {