HDDS-1745. Add integration test for createDirectory for OM HA #1304
Conversation
|
Can you give me some suggestions on this PR:
|
| objectStore.createVolume(volumeName); | ||
| objectStore.getVolume(volumeName).createBucket(bucketName); | ||
|
|
||
| OMRequest request = OMRequest.newBuilder().setCreateDirectoryRequest( |
There was a problem hiding this comment.
We do not need this kind of tests, they are covered in UT.
We can use createDirectory API and test create Directory functionality.
Test cases can be:
- single level path ('/dir)
- Multi-level ('/dir1/dir2')
- Few parents exist in multi-level path
- Already a directory exists with the same name
any other cases you want to add :)
There was a problem hiding this comment.
@bharatviswa504 thank you!
I was confused on which createDirectory API it is. Can you paste a link here so I have better understanding on the context?
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah interesting..
If I run
bucket.createDirectory("/dir1");
bucket.createDirectory("/dir1");
The test will still pass without a complain. I expect an exception should be thrown.
I will check the internal of OM to see how does CreateDirectory API work, and see if there is anything can be improved.
There was a problem hiding this comment.
I am currently have a problem to verify that a directory is created successfully.
What is the API to retrieve the information of directory? Seems that it is not considered as a key or a file so either getKey and getFileStatus does not work.
Basically I can do
bucket.createDirectory("/dir1"); then I need to do a bucket.getDirectoryStatus.
I also tried another direction: after a createDirectory call, try to put a file to that directory and then read that file to justify that createDirectory succeed. Later I realized this also does not work because without createDirectory, the create file call will always work even for multiple level directory (e.g. /dir1/dir2/dir3/file).
|
/pending |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
What changes were proposed in this pull request?
Add an integration test for createDirectory which is implemented as part of HDDS-1730 for OM HA.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-1745
How was this patch tested?
Integration Test.