Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-4419. Misleading SCM web UI Safe mode status #1599

Merged
merged 2 commits into from Jan 6, 2021
Merged

Conversation

elek
Copy link
Member

@elek elek commented Nov 18, 2020

What changes were proposed in this pull request?

Improve the usability of SafeMode rule table on the web ui.
See the reports in the JIRA.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4419

How was this patch tested?

Started and checked the UI

@elek elek requested a review from jojochuang November 18, 2020 14:08
@elek elek changed the title HDDS-4419. Add metrics for closed container replication HDDS-4460. Add metrics for closed container replication Nov 23, 2020
@jojochuang
Copy link
Contributor

Looks good to me, but I was confused initially. This PR was raised for HDDS-4419, isn't it?
Would be nice to take a screenshot, though not required.

@elek elek changed the title HDDS-4460. Add metrics for closed container replication HDDS-4419. Misleading SCM web UI Safe mode status Dec 3, 2020
@elek
Copy link
Member Author

elek commented Dec 3, 2020

Looks good to me, but I was confused initially. This PR was raised for HDDS-4419, isn't it?

yes, sorry for the confusion. Fixing.

(Second PR where I made this mistake. For me this double accounting (jira + github) couldn't help.)

@elek
Copy link
Member Author

elek commented Dec 4, 2020

This is the screenshot (of the relevant part):

image

Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx.

@elek
Copy link
Member Author

elek commented Jan 6, 2021

Merging it now. Thanks the review @jojochuang

@elek elek merged commit 8146368 into apache:master Jan 6, 2021
jojochuang pushed a commit to jojochuang/ozone that referenced this pull request Mar 11, 2021
(cherry picked from commit 8146368)
Change-Id: If029bf3400eba0b8a01bcf43901aa797d8ce68f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants