HDDS-4606. Detect and handle duplicate ACLs when set default ACLs #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masstter
changed the title
xiaoyuyao
reviewed
Dec 20, 2020
added 2 commits
December 21, 2020 13:24
…tedly, add handle adding different acl rights to existing acl entry
…tedly, add handle adding different acl rights to existing acl entry
|
@xiaoyuyao Thanks for reviews, it's helped me a lot, added handle adding different acl rights to existing acl entry in my new changes |
ChenSammi
changed the title
ChenSammi
changed the title
ChenSammi
changed the title
ChenSammi
reviewed
Dec 23, 2020
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmOzoneAclMap.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmOzoneAclMap.java
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmOzoneAclMap.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmOzoneAclMap.java
Show resolved
Hide resolved
|
+1. Thanks @masstter for the contribution and @xiaoyuyao for the code review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HDDS-4606. Got wrong ACL(s) when set default ACL(s) on volume for repeatedly
What changes were proposed in this pull request?
ignored duplicate entity when adding volume default ACL(s)
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4606
How was this patch tested?
updating ACL(s) repeatedly, then using ozone CLI to check ACL(s), it's not repeating -- passed
