Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-4647. Avoid hadoop-ozone-filesystem-shaded as transitive dependency #1761

Merged
merged 3 commits into from Jan 7, 2021

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

If hadoop-ozone-filesystem-hadoop2 or hadoop-ozone-filesystem-hadoop3 is added as dependency in some project, hadoop-ozone-filesystem-shaded is included as a transitive dependency. But it should not be required for such downstream projects, as both Hadoop version-specific modules already repackage most of it. This change marks the dependency as optional (doc) so that such projects do not need to add exclusion for this module.

https://issues.apache.org/jira/browse/HDDS-4647

How was this patch tested?

Checked dependency tree of downstream project no longer includes hadoop-ozone-filesystem-shaded:

[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ tez ---
[INFO] ...
[INFO] +- jdk.tools:jdk.tools:jar:1.8:system
[INFO] \- org.apache.hadoop:hadoop-ozone-filesystem-hadoop3:jar:1.1.0-SNAPSHOT:runtime
[INFO] ------------------------------------------------------------------------

Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/465890389

@adoroszlai adoroszlai self-assigned this Jan 6, 2021
Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 thanks the fix @adoroszlai

Pending on CI

@adoroszlai adoroszlai merged commit 7c21518 into apache:master Jan 7, 2021
@adoroszlai
Copy link
Contributor Author

Thanks @elek and @mukul1987 for the review.

@adoroszlai adoroszlai deleted the HDDS-4647 branch January 7, 2021 19:32
jojochuang pushed a commit to jojochuang/ozone that referenced this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants