HDDS-4673. NodeStateMap leaks internal representation of container sets #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elek
changed the title
nandakumar131
approved these changes
Jan 12, 2021
|
Thanks @elek for taking care of this. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Mar 11, 2021
…container sets. (apache#1782) (cherry picked from commit a8f4d52) Change-Id: I216148aa1f57eb8b701f8f28f2b7ed6022c0454b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/HDDS-4673
What changes were proposed in this pull request?
@jojochuang reported that some
ConcurrentModificationExceptionis visible even after #1174 (https://issues.apache.org/jira/browse/HDDS-3918)The root cause of this issue is a leak of internal representation of sets in
NodeStateMap.NodeStateMapreturns an unmodifiable copy of containers for one specific node:With this approach the users of the
nodeStateMap.getContainersmethod couldn't modify the set anymore. ButnodeStateMapcan modify the original set which is referenced (instead of copy) by theunmodifiableSet. Even if it's unmodifiable it throws an exception during the iteration if the original set is modified in the background.How was this patch tested?
There is a new unit test method which reproduce the specific race condition with the help of
CountDownLatch-es