HDDS-4742. Make trash work with FS Optimised Buckets. #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elek
changed the title
amaliujia
reviewed
Feb 10, 2021
...p-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystemV1.java
Outdated
Show resolved
Hide resolved
amaliujia
reviewed
Feb 10, 2021
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/TrashOzoneFileSystem.java
Outdated
Show resolved
Hide resolved
|
@sadanand48 |
sadanand48
force-pushed
the
HDDS-4742
branch
from
f6cf0b5
to
e5dacae
Compare
rakeshadr
reviewed
Feb 16, 2021
There was a problem hiding this comment.
Thanks @sadanand48 for the good work. Added few comments, please take a look at it.
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OzoneFSUtils.java
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/TrashOzoneFileSystem.java
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/TrashOzoneFileSystem.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/TrashOzoneFileSystem.java
Show resolved
Hide resolved
|
Thanks @rakeshadr for the review. Addressed comments. |
rakeshadr
reviewed
Feb 16, 2021
There was a problem hiding this comment.
Thanks @sadanand48 for the updated patch. Overall PR looks good, just added a minor typo and one point to clarify.
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OzoneFSUtils.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/TrashOzoneFileSystem.java
Show resolved
Hide resolved
|
Thanks @sadanand48 for the contribution. +1 for the changes. Waiting for the QA report. |
rakeshadr
approved these changes
Feb 16, 2021
rakeshadr
pushed a commit
that referenced
this pull request
Feb 18, 2021
rakeshadr
pushed a commit
that referenced
this pull request
Feb 25, 2021
rakeshadr
pushed a commit
that referenced
this pull request
Mar 3, 2021
rakeshadr
pushed a commit
that referenced
this pull request
Mar 9, 2021
rakeshadr
pushed a commit
that referenced
this pull request
Mar 27, 2021
rakeshadr
pushed a commit
that referenced
this pull request
Apr 7, 2021
rakeshadr
pushed a commit
that referenced
this pull request
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Integrate trash with HDDS-2939.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4742
How was this patch tested?
testTrash() run through TestOzoneFileSystemV1 configs.