Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-4845. Update NodeStatus OperationalState for Datanodes in Recon #1939

Merged
merged 3 commits into from Feb 19, 2021

Conversation

smengcl
Copy link
Contributor

@smengcl smengcl commented Feb 19, 2021

https://issues.apache.org/jira/browse/HDDS-4845

Possibly due to Recon ignoring setNodeOperationalStateCommand (HDDS-4766), NodeStatus isn't being updated for its operationalState and opStateExpiryEpochSeconds fields (but DatanodeInfo's persistedOpState and persistedOpStateExpiryEpochSec are correct):

discrepancy

How was this patch tested?

  • Tested manually so far with temporarily inserted assertions.
  • Updated UT.

Change-Id: I09c5e079783d94169a3e298715dacfc797578471
@smengcl smengcl added the bug Something isn't working label Feb 19, 2021
@smengcl smengcl self-assigned this Feb 19, 2021
Change-Id: I54ed0f38bdb245501ca1106b14dad7144a939ae9
Change-Id: Ib9eb281257c6143c4f551f4fe50c937a496337dc
Copy link
Contributor

@sodonnel sodonnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM. Thanks for fixing this - feel free to go ahead and commit.

@smengcl
Copy link
Contributor Author

smengcl commented Feb 19, 2021

Thanks @sodonnel for reviewing this. Will merge shortly.

@smengcl smengcl merged commit 96e27a5 into apache:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants