HDDS-4995. Skip CI for draft pull requests #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukul1987
force-pushed
the
master
branch
2 times, most recently
from
79a9d39
to
520ba00
Compare
|
@adoroszlai , how can github actions be enabled on forks ? |
@mukul1987 https://github.com/mukul1987/hadoop-ozone/actions/workflows/post-commit.yml - I think you as repo owner should see a button: "Enable workflow". |
elek
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
+1, thanks for the improvement @adoroszlai
Apache organization has a shared github actions pool (180 executors AFAIK) for all the Apache projects, we need to minimize the action executions when it's reasonable....
|
Thanks @dineshchitlangia and @elek for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Github pull requests can be created as (or converted to) draft. This is useful for gathering early feedback from other contributors about proof-of-concept code. Such code may not even compile, and style issues are usually ignored.
Since further commits are generally expected in this case, I think it makes sense to skip CI build/test until the PR is marked as "ready for review". The goal is to save CI cycles for other issues.
If CI feedback is desired, the author should enable workflows in their fork so we can check push builds there.
https://issues.apache.org/jira/browse/HDDS-4995
How was this patch tested?
Tested with a draft PR in my fork: adoroszlai#12
Builds:
Also with this PR: