Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-5018.[FSO] Add robot tests for new Filesystem layout #2071

Merged
merged 7 commits into from
Apr 6, 2021

Conversation

sadanand48
Copy link
Contributor

What changes were proposed in this pull request?

Add robot test for the new FS Layout

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-5018

How was this patch tested?

Acceptance tests

Copy link
Contributor

@mukul1987 mukul1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes generally look good to me. Lets wait for the CI results

@adoroszlai
Copy link
Contributor

  1. .env file is missing from the new compose directory, so acceptance test is failing:
    The OZONE_RUNNER_VERSION variable is not set. Defaulting to a blank string.
    no such image: apache/ozone-runner:: invalid reference format
    
  2. Can we find a way to avoid duplicating the compose environment just for testing with slightly different config?

@sadanand48
Copy link
Contributor Author

Thanks @adoroszlai for the comment.
By not duplicating the compose environment do you mean adding this test to an existing environment (inside ozone/test.sh) or not duplicate the docker-compose.yaml file?

@adoroszlai
Copy link
Contributor

By not duplicating the compose environment do you mean adding this test to an existing environment (inside ozone/test.sh) or not duplicate the docker-compose.yaml file?

I don't have a definitive answer for that (that's what I meant by "find a way"). Hopefully we can achieve it in the first way, ie. without any duplication.

One idea is to define relevant configs as environment variables directly in test.sh, instead of the static docker-config file. With that, we can execute the same test suite with different configs by including start/stop_docker_env in the loop.

@adoroszlai
Copy link
Contributor

One idea is to define relevant configs as environment variables directly in test.sh, instead of the static docker-config file. With that, we can execute the same test suite with different configs by including start/stop_docker_env in the loop.

Here's an implementation of this:
adoroszlai@dd2d586

And the test run:
https://github.com/adoroszlai/hadoop-ozone/runs/2192093559?check_suite_focus=true

@sadanand48
Copy link
Contributor Author

Here's an implementation of this:
adoroszlai@dd2d586

And the test run:
https://github.com/adoroszlai/hadoop-ozone/runs/2192093559?check_suite_focus=true

Thanks a lot @adoroszlai for demonstrating this. I have tried something similar . Please take a look.

@mukul1987
Copy link
Contributor

@sadanand48 can you please rebase the patch.

Copy link
Contributor

@mukul1987 mukul1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, the changes looks good to me.

@rakeshadr
Copy link
Contributor

rakeshadr commented Apr 6, 2021

Thanks @sadanand48 for the contribution.
Thanks @adoroszlai , @mukul1987 for the reviews.

+1 LGTM, will merge it.

@rakeshadr rakeshadr merged this pull request into apache:HDDS-2939 Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants