-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-5018.[FSO] Add robot tests for new Filesystem layout #2071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes generally look good to me. Lets wait for the CI results
|
Thanks @adoroszlai for the comment. |
I don't have a definitive answer for that (that's what I meant by "find a way"). Hopefully we can achieve it in the first way, ie. without any duplication. One idea is to define relevant configs as environment variables directly in |
Here's an implementation of this: And the test run: |
Thanks a lot @adoroszlai for demonstrating this. I have tried something similar . Please take a look. |
@sadanand48 can you please rebase the patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, the changes looks good to me.
Thanks @sadanand48 for the contribution. +1 LGTM, will merge it. |
What changes were proposed in this pull request?
Add robot test for the new FS Layout
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5018
How was this patch tested?
Acceptance tests