Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-5038. Create and update ZH translation of SCM-HA.md and OM-HA.md in doc #2092

Merged
merged 4 commits into from Apr 8, 2021

Conversation

sky76093016
Copy link
Contributor

What changes were proposed in this pull request?

Increase translation documents for SCM-HA and OM-HA.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-5038

How was this patch tested?

Local test.

@sky76093016 sky76093016 changed the title HDDS-5038. Create and update ZH translation of SCM-HA.md and OM-HA.md… HDDS-5038. Create and update ZH translation of SCM-HA.md and OM-HA.md in doc Mar 29, 2021
@bshashikant bshashikant changed the base branch from HDDS-2823 to master March 30, 2021 07:15
@@ -0,0 +1,162 @@
---
title: "SCM 高可用"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested title: 高可用SCM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solve it.
Does the title of OM-HA.zh.md need to be changed to ‘高可用OM’?

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sky76093016 for the patch. It LGTM overall, a few comments added inline.

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sky76093016 for the contribution. LGTM, +1.

@xiaoyuyao xiaoyuyao merged commit b83c7b6 into apache:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants