HDDS-4495. [FSO]Delete : Implement async cleanup of garbage and orphan sub-dirs/files #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linyiqun
reviewed
Mar 30, 2021
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
Outdated
Show resolved
Hide resolved
...p-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/DirectoryDeletingService.java
Show resolved
Hide resolved
linyiqun
reviewed
Mar 31, 2021
...ntegration-test/src/test/java/org/apache/hadoop/fs/ozone/TestDirectoryDeletingServiceV1.java
Outdated
Show resolved
Hide resolved
linyiqun
reviewed
Mar 31, 2021
...ntegration-test/src/test/java/org/apache/hadoop/fs/ozone/TestDirectoryDeletingServiceV1.java
Outdated
Show resolved
Hide resolved
linyiqun
reviewed
Mar 31, 2021
...ntegration-test/src/test/java/org/apache/hadoop/fs/ozone/TestDirectoryDeletingServiceV1.java
Outdated
Show resolved
Hide resolved
|
Thanks again @linyiqun for the review comments. I've updated PR by addressing the comments. |
linyiqun
approved these changes
Apr 6, 2021
|
Thanks a lot @linyiqun, I will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implements a service to get the pending orphan directories and clean up its sub-paths(subdirs and subfiles). Sub-files will be added to existing KeyDeletinService where it will ask scm to clean its blocks, is any.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4495
How was this patch tested?
Added a few cases, will add more cases to it.
Raised followup jira to verify KDS HDDS-5042