Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-5234. Change default grpc and ratis ports for scm ha #2251

Merged
merged 1 commit into from May 17, 2021

Conversation

sadanand48
Copy link
Contributor

@sadanand48 sadanand48 commented May 17, 2021

What changes were proposed in this pull request?

Currently, by default scm ratis and scm grpc ports are defined to be 9865 and 9866 by default. These ports are also used for datanode https and datanode ports for hdfs by default hence may lead to port conflict issue in ozone deployment alongside hdfs . These ports are replaced with port numbers 9894 and 9895 respectively.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-5234

How was this patch tested?

Tested manually on a docker scm ha cluster

@sadanand48 sadanand48 changed the title HDDS-5234.Change default grpc and ratis ports for scm ha HDDS-5234. Change default grpc and ratis ports for scm ha May 17, 2021
@bharatviswa504
Copy link
Contributor

bharatviswa504 commented May 17, 2021

This might have some impact for someone who is using from the apache/master branch.
Mostly the port for SCM Ratis and Grpc Port is changed so after the upgrade SCM Ratis and Grpc will start on new ports. Is this only the impact or there any impact other than this?

cc @GlenGeng

@GlenGeng-awx
Copy link
Contributor

Thanks @bharatviswa504 for the notification! We are fine with this change.

We will explicitly set the ratis port and grpc port to 9865 and 9866 respectively before next upgrade, so that our running cluster will keep using the old port, thus not be affected.

@bharatviswa504
Copy link
Contributor

Thanks @bharatviswa504 for the notification! We are fine with this change.

We will explicitly set the ratis port and grpc port to 9865 and 9866 respectively before next upgrade, so that our running cluster will keep using the old port, thus not be affected.

Thanks @GlenGeng for the confirmation.

@bharatviswa504
Copy link
Contributor

bharatviswa504 commented May 17, 2021

I am +1, as this is a progress feature, mostly it will not be used by others.

But if someone is using they can follow a similar suggestion by @GlenGeng adding the port configs with the previous value.

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bharatviswa504 bharatviswa504 merged commit 91993c1 into apache:master May 17, 2021
@bharatviswa504
Copy link
Contributor

Thank You @sadanand48 for the contribution.

bharatviswa504 pushed a commit to bharatviswa504/hadoop-ozone that referenced this pull request Jul 25, 2021
(cherry picked from commit 91993c1)
Change-Id: I38b33cf3a217ea2e361738c88db902e6b8b107cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants