New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-1572 Implement a Pipeline scrubber to clean up non-OPEN pipeline. #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyuyao
reviewed
Nov 20, 2019
.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/BackgroundPipelineCreator.java
Outdated
Show resolved
Hide resolved
xiaoyuyao
reviewed
Nov 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just one question commented inline.
timmylicheng
force-pushed
the
HDDS-1572
branch
2 times, most recently
from
November 21, 2019 03:44
ed1c848
to
9189eef
Compare
/retest |
/retest |
@elek Hey, wonder why this PR didn't run CI. Could you take a look? |
timmylicheng
force-pushed
the
HDDS-1572
branch
3 times, most recently
from
November 25, 2019 08:06
06499e8
to
0677cfd
Compare
/retest |
timmylicheng
force-pushed
the
HDDS-1572
branch
2 times, most recently
from
November 25, 2019 12:05
9b720a7
to
73c771e
Compare
ChenSammi
reviewed
Nov 26, 2019
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
Outdated
Show resolved
Hide resolved
.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/BackgroundPipelineCreator.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java
Show resolved
Hide resolved
timmylicheng
force-pushed
the
HDDS-1572
branch
from
November 26, 2019 14:21
73c771e
to
6c7b77c
Compare
LGTM. + 1. Will commit it soon. |
ChenSammi
pushed a commit
that referenced
this pull request
Dec 3, 2019
timmylicheng
added a commit
to timmylicheng/hadoop-ozone
that referenced
this pull request
Dec 23, 2019
timmylicheng
added a commit
to timmylicheng/hadoop-ozone
that referenced
this pull request
Jan 7, 2020
timmylicheng
added a commit
to timmylicheng/hadoop-ozone
that referenced
this pull request
Feb 10, 2020
timmylicheng
added a commit
to timmylicheng/hadoop-ozone
that referenced
this pull request
Feb 12, 2020
anuengineer
pushed a commit
that referenced
this pull request
Feb 19, 2020
* HDDS-1577. Add default pipeline placement policy implementation. (#1366) (cherry picked from commit b640a5f6d53830aee4b9c2a7d17bf57c987962cd) * HDDS-1571. Create an interface for pipeline placement policy to support network topologies. (#1395) (cherry picked from commit 753fc6703a39154ed6013e44dbae572391748906) * HDDS-2089: Add createPipeline CLI. (#1418) (cherry picked from commit 326b5acd4a63fe46821919322867f5daff30750c) * HDDS-1569 Support creating multiple pipelines with same datanode. Contributed by Li Cheng. This closes #28 * HDDS-1572 Implement a Pipeline scrubber to clean up non-OPEN pipeline. (#237) * Rebase Fix * HDDS-2650 Fix createPipeline CLI. (#340) * HDDS-2035 Implement datanode level CLI to reveal pipeline relation. (#348) * Revert "HDDS-2650 Fix createPipeline CLI. (#340)" This reverts commit 7c71710. * HDDS-2650 Fix createPipeline CLI and make it message based. (#370) * HDDS-1574 Average out pipeline allocation on datanodes and add metrcs/test (#291) * Resolve rebase conflict. * HDDS-2756. Handle pipeline creation failure in different way when it exceeds pipeline limit Closes #401 * HDDS-2115 Add acceptance test for createPipeline CLI and datanode list CLI (#375) * HDDS-2115 Add acceptance test for createPipeline CLI and datanode list CLI. * HDDS-2772 Better management for pipeline creation limitation. (#410) * HDDS-2913 Update config names and CLI for multi-raft feature. (#462) * HDDS-2924. Fix Pipeline#nodeIdsHash collision issue. (#478) * HDDS-2923 Add fall-back protection for rack awareness in pipeline creation. (#516) * HDDS-3007 Fix CI test failure for TestSCMNodeManager. (#550) Co-authored-by: Sammi Chen <sammichen@apache.org> Co-authored-by: Xiaoyu Yao <xyao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#HDDS-1572
Implement a Pipeline scrubber to maintain healthy number of pipelines in a cluster
What is the link to the Apache JIRA
#HDDS-1572
https://issues.apache.org/jira/browse/HDDS-1572
(Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)
Please replace this section with the link to the Apache JIRA)
How was this patch tested?
UT
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)