HDDS-5405. Refactor pom files for HadoopRpc and Grpc/Ratis compilation properties. #2386
Conversation
There was a problem hiding this comment.
Thanx @mukul1987 for the work here:
Guess you need to update here as well:
https://github.com/apache/ozone/blob/master/hadoop-hdds/common/src/main/resources/hdds-version-info.properties#L26
Else on ozone version it isn't printing the protobuf version, give a check once
Source code repository https://github.com/apache/hadoop-ozone.git -r 2e802035524be64323c9ba51d49aa6743b2fc1e7
Compiled by ayushsaxena on 2021-07-05T05:04Z
Compiled with protoc ${protobuf.version}
From source with checksum fe96641cc7e1e3154a11d5656a18992
With Apache Ratis: 2.1.0-ff8aa66-SNAPSHOT from ff8aa668f1a0569ba5e6b0f30dbd51a673913344
Using HDDS 1.2.0-SNAPSHOT
Source code repository https://github.com/apache/hadoop-ozone.git -r 2e802035524be64323c9ba51d49aa6743b2fc1e7
Compiled by ayushsaxena on 2021-07-05T05:03Z
Compiled with protoc ${protobuf.version}
From source with checksum 2195247c589f9b7ac11c30949830147
There was a problem hiding this comment.
Just to clarify my understanding, where we use hadoop rpc we use hadoop.rpc.version, where we use ratis grpc like datanode, we use grpc protobuf version.
And also one more question, We have proto version printing previously hadoop rpc protobuf version, a question do we want to add 2 one with hadoop rpc and other grpc protobuf version also?
|
Thanks for the reviews @ayushtkn and @bharatviswa504, I have addressed the review comments. Also, I have created a jira to harmonize the protobuf version across both protocols. |
Yes, thats correct. I am now also including the protobuf versions in the output. |
* master: (28 commits) HDDS-5332. Add a new column family and a service provider in Recon DB for Namespace Summaries (apache#2366) HDDS-5405. Refactor pom files for HadoopRpc and Grpc/Ratis compilation properties. (apache#2386) HDDS-5406. add proto version to all the proto files. (apache#2385) HDDS-5398. Avoid object creation in ReplicationManger debug log statements (apache#2379) HDDS-5396. Fix negligence issue conditional expressions in MockCRLStore.java (apache#2380) HDDS-5395. Avoid unnecessary numKeyOps.incr() call in OMMetrics (apache#2374) HDDS-5389. Include ozoneserviceid in fs.defaultFS when configuring o3fs (apache#2370) HDDS-5383. Eliminate expensive string creation in debug log messages (apache#2372) HDDS-5380. Get more accurate space info for DedicatedDiskSpaceUsage. (apache#2365) HDDS-5341. Container report processing is single threaded (apache#2338) HDDS-5387. ProfileServlet to move the default output location to an ozone specific directory (apache#2368) HDDS-5289. Update container's deleteTransactionId on creation of the transaction in SCM. (apache#2361) HDDS-5369. Cleanup unused configuration related to SCM HA (apache#2359) HDDS-5381. SCM terminated with exit status 1: null. (apache#2362) HDDS-5353. Avoid unnecessary executeBatch call in insertAudits (apache#2342) HDDS-5350 : Add allocate block support in MockOmTransport (apache#2341). Contributed by Uma Maheswara Rao G. HDDS-4926. Support start/stop for container balancer via command line (apache#2278) HDDS-5269. Datandoe with low ratis log volume space should not be considered for new pipeline allocation. (apache#2344) HDDS-5367. Update modification time when updating quota/storageType/versioning (apache#2355) HDDS-5352. java.lang.ClassNotFoundException: org/eclipse/jetty/alpn/ALPN (apache#2347) ...
What changes were proposed in this pull request?
Refactor the pom files to differentiate proto files compiled for hadooprpc and grpc related proto files
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5405
How was this patch tested?
compilation succeeds and existing unit tests pass