Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-5538. Uncaught NPE in GrpcReplicationService. #2503

Merged
merged 3 commits into from Aug 9, 2021
Merged

HDDS-5538. Uncaught NPE in GrpcReplicationService. #2503

merged 3 commits into from Aug 9, 2021

Conversation

ChenSammi
Copy link
Contributor

@adoroszlai adoroszlai changed the title HDDS-5538. Uncatched NPE in GrpcReplicationService. HDDS-5538. Uncaught NPE in GrpcReplicationService. Aug 5, 2021
jojochuang
jojochuang reviewed Aug 6, 2021
View reviewed changes
...n/java/org/apache/hadoop/ozone/container/replication/OnDemandContainerReplicationSource.java Outdated
Preconditions.checkNotNull(
container, "Container is not found " + containerId);
if (container == null) {
throw new StorageContainerException("Container not found",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to add container id too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

@jojochuang jojochuang merged commit bc1dfb8 into apache:master Aug 9, 2021
@ChenSammi
Copy link
Contributor Author

Thanks @jojochuang for the code review.

errose28 added a commit to errose28/ozone that referenced this pull request Aug 9, 2021
@errose28
Merge branch 'master' into HDDS-5432-no-downgrade-action
355ca2d 
* master: (24 commits)
  HDDS-5503. On finalize upgrade actions not running. (apache#2476)
  HDDS-5390. reconPipelineReportHandler should not retry when pipeline not found (apache#2371)
  HDDS-5538. Uncaught NPE in GrpcReplicationService. (apache#2503)
  HDDS-5473. Bump jetty version to 9.4.43.v20210629 (apache#2449)
  HDDS-5516. Duplicate metrics registered while running checkScmHA upon scm startup. (apache#2475)
  HDDS-4668. Intermittent failure in TestOMRatisSnapshots (apache#2474)
  HDDS-5527. Move tests back to root partition (apache#2486)
  HDDS-5532. Missing integration test cleanup (apache#2496)
  HDDS-5354. Allow to restrict available ReplicationConfig  (apache#2345)
  HDDS-5539. Fix actual value in assertion in TestRDBStore (apache#2494)
  HDDS-5441. Disallow same set of DNs to be part of multiple pipelines.  (apache#2416)
  HDDS-5530. Support links to encrypted buckets. (apache#2487)
  HDDS-5515. SKip update firstUpgradeActionLayoutVersion when on-disk layout version is up-to-date. (apache#2472)
  HDDS-5460: ReplicationConfig#getDefault is hardcoded with RatisReplicationConfig (apache#2430)
  HDDS-5472. Old versions of location in OmKeyLocationInfoGroup causes OOM of OM (apache#2448)
  HDDS-5302. CleanUp V1 Code of DeletedBlockLogImpl (apache#2465)
  HDDS-5362. [FSO] Support bucket layouts in OM (apache#2357)
  HDDS-5511. ContainerStateMap should handle ecReplication config map (apache#2470)
  HDDS-5501. Support to upload/read keys from encrypted buckets through S3G (apache#2467)
  HDDS-5512. Intermittent failure in TestSCMInstallSnapshotWithHA (apache#2473)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jojochuang jojochuang jojochuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ChenSammi @jojochuang