HDDS-5670. ContainerBalancer should get OzoneConfiguration from ContainerBalancerConfiguration. #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inerBalancerConfiguration.
|
@lokeshj1703 @JacksonYao287 please take a look. |
There was a problem hiding this comment.
thanks @siddhantsangwan for this work, the changes looks good ! i have a minor comment inline, please take a look
| @@ -111,10 +111,14 @@ | |||
| */ | |||
| public ContainerBalancerConfiguration( | |||
| OzoneConfiguration ozoneConfiguration) { | |||
| this.ozoneConfiguration = ozoneConfiguration; | |||
| if (ozoneConfiguration == null) { | |||
There was a problem hiding this comment.
actually, ozoneConfiguration should not be null. we'd better to use Preconditions.checkNotNull instead here.
|
@JacksonYao287 thanks for the review! I've updated according to your comment. |
JacksonYao287
approved these changes
Sep 8, 2021
lokeshj1703
approved these changes
Sep 9, 2021
lokeshj1703
changed the title
|
@siddhantsangwan Thanks for the contribution! @JacksonYao287 Thanks for the review! I have committed the PR to master branch. |
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Sep 10, 2021
* master: (21 commits) HDDS-5502. [OFS] URI parser throws URISyntaxException when path contains space (apache#2500) HDDS-5715. Make XceiverServerRatis#raftGids a thread-safe set. (apache#2613) HDDS-5699. Added Log to show why a container was marked UNHEALTHY. (apache#2627) HDDS-5723. Increase time limit of Ozone acceptance tests. (apache#2620) HDDS-5718. Refactor TestXceiverClientManager to reuse mini-clusters (apache#2616) HDDS-5724. Add RaftpeerId when getting scm roles (apache#2622) HDDS-5711. support -1 for running balancer infinitely (apache#2621) HDDS-5670. ContainerBalancer should get OzoneConfiguration from ContainerBalancerConfiguration. (apache#2577) HDDS-5638. Fix docker-compose to make Recon come up. (apache#2563) HDDS-5726. Skip remove for already removed pipeline. (apache#2624) HDDS-5719. Reduce number of mini-clusters needed for decommission tests (apache#2617) HDDS-5716. Fix create key failure error log print (apache#2614) HDDS-5678. Handle unsecure SCM HA converted to secure SCM HA. (apache#2596) HDDS-5432. Enable downgrade testing after 1.1.0 release. (apache#2484) HDDS-5709. do not call removeTransactionsFromDB if nothing to remove (apache#2608) HDDS-5700. Improve LOG message of decommission progress. (apache#2598) HDDS-5690. Speed up TestContainerReplication by removing testSkipDemmissionAndMaintenanceNode (apache#2591) HDDS-5706. Fix ReplicationManager zero metrics for inflight actions. (apache#2605) HDDS-5667. documentation page layout (apache#2604) HDDS-5644. Speed up decommission tests using a background Mini Cluster provider (apache#2554) ...
sadanand48
pushed a commit
that referenced
this pull request
Oct 2, 2021
…inerBalancerConfiguration. (#2577)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, ContainerBalancer creates a new OzoneConfiguration in ContainerBalancer#start and uses that. Instead, it should get the OzoneConfiguration object from ContainerBalancerConfiguration.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5670
How was this patch tested?
TestContainerBalancer UT