HDDS-5788. Reduce run time for TestOzoneManagerHA tests #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodonnel
reviewed
Sep 28, 2021
...ntegration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAWithFailover.java
Show resolved
Hide resolved
|
Thanks @JyotinderSingh for the contribution. It looks to me the TestBlockDeletion failure is unrelated to your change, please re-trigger the build by doing another commit in the PR like,
|
rakeshadr
reviewed
Sep 29, 2021
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHA.java
Outdated
Show resolved
Hide resolved
...ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerPrepare.java
Show resolved
Hide resolved
|
Seems like testOmRestart() is taking long to execute. Adding changes to make it execute on a fresh cluster. |
|
This seems like an unrelated failure in the client integration-test. Re-triggering CI. |
JyotinderSingh
force-pushed
the
HDDS-5788
branch
from
deb9ef6
to
15a0862
Compare
added 8 commits
September 29, 2021 22:02
JyotinderSingh
force-pushed
the
HDDS-5788
branch
from
15a0862
to
21c8d06
Compare
rakeshadr
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
+1 LGTM
@JyotinderSingh, Good Work! Thanks for the contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently tests under TestOzoneManagerHA take long to execute since MiniOzoneClusterHA is setting up freshly for each test case.
This is a proposal to spin up a shared MiniOzoneClusterHA for all the tests extending TestOzoneManagerHA, allowing them to reuse the same cluster and not have to spin up a new one every time.
This brings down the cumulative time to run all suites extending TestOzoneManagerHA down from ~720s to ~260s
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5788
Please replace this section with the link to the Apache JIRA)
How was this patch tested?
Manual Testing