Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-5793. Speed up TestBlockOutputStreamWithFailures by combining test cases #2690

Merged
merged 2 commits into from Oct 1, 2021

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Combine some test cases in TestBlockOutputStreamWithFailures and TestBlockOutputStreamWithFailuresFlushDelay to reduce cluster creation/startup time.

https://issues.apache.org/jira/browse/HDDS-5793

How was this patch tested?

Before:

[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 585.121 s - in org.apache.hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailuresFlushDelay
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 584.137 s - in org.apache.hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

https://github.com/apache/ozone/runs/3728055559#step:4:2863

After:

[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 294.082 s - in org.apache.hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailuresFlushDelay
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 278.229 s - in org.apache.hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

https://github.com/adoroszlai/hadoop-ozone/runs/3732932406#step:4:2892

@adoroszlai adoroszlai self-assigned this Sep 28, 2021
@adoroszlai adoroszlai marked this pull request as draft September 28, 2021 18:09
@adoroszlai adoroszlai marked this pull request as ready for review September 29, 2021 17:35
@adoroszlai
Copy link
Contributor Author

adoroszlai commented Sep 29, 2021

Slightly less time saved (still around 5 minutes) with the new grouping, but hopefully it is more stable.

[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 418.874 s - in org.apache.hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailuresFlushDelay
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 421.035 s - in org.apache.hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

Copy link
Contributor

@sodonnel sodonnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adoroszlai adoroszlai merged commit 53a0009 into apache:master Oct 1, 2021
@adoroszlai adoroszlai deleted the HDDS-5793 branch October 1, 2021 14:01
@adoroszlai
Copy link
Contributor Author

Thanks @bshashikant and @sodonnel for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants