HDDS-5722 [HTTPFSGGW] junit.jar and json-simple in jar report #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fapifta
approved these changes
Oct 18, 2021
There was a problem hiding this comment.
Thank you @dombizita for taking this on, the changes look good, +1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The HTTPFS branch contains junit.jar and json-simple.jar in its jar-report.txt and we wanted to investigate this and try to remove/replace them.
We wanted to replace json-simple with json-smart, as it is already in the jar-report. I found that the json-smart.jar is added as a "hack". In the ozone-main pom.xml a comment says that it is added as transitive dependency for nimbus-jose-jwt, it is needed for packaging. We agreed not to use json-smart instead of json-simple, as json-smart is planned to be removed in the future. Classes in the httpfsgateway are using json-simple (JSONObject, JSONArray, JSONParser, etc.), so that will stay in the jar-report.
The junit.jar is coming from the json-simple.jar as a compile time dependency, so I excluded it in the pom.xml.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5722
How was this patch tested?
Run the build manually with skip tests and the build was successful. Also run the dependency.sh from the dev-support directory and it was successful.