-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-5916. Add IP check when DN register to SCM #2802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Question for already created pipelines, will there be any issue/how is it handled?
The old pipelines would get stuck in leader election, timeout and then get closed for some DN being candidate too long. |
e59fb4d
to
a77b09f
Compare
@Xushaohong re:
Does this mean that eventually after some timeout that the leader election is resolved? Or does it perpetuate for any previously created pipelines? |
The previously created pipelines would be closed after timeout, and new pipelines, most of them would work normally, except one or two still dangling. @techwhizbang |
I think this problem is more completely addressed in #3186. |
Thx for this information! I will close this PR. |
What changes were proposed in this pull request?
SCM doesn't upgrade DN NodeInfo if any DN restarts.
This causes the issue described in the JIRA, which in k8s env would lead to unavailable cluster conditions.
Thus, we should add this case to upgrade the LastknownIpAddress of Datanodes to NodeMap when they register again.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5916
How was this patch tested?
Manual Test on K8s